Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HPA target #361

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

sydorovdmytro
Copy link
Contributor

Fixes an issue with HPA autoscaling/v2:

* HorizontalPodAutoscaler.autoscaling "reflector" is invalid: [spec.metrics[0].resource.target.type: Required value: must specify a metric target type, spec.metrics[0].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[0].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization]

Docs: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/

Fixes an issue with HPA autoscaling/v2:
* HorizontalPodAutoscaler.autoscaling "reflector" is invalid: [spec.metrics[0].resource.target.type: Required value: must specify a metric target type, spec.metrics[0].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[0].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization]

Docs: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
@sydorovdmytro
Copy link
Contributor Author

Hello @winromulus, please have a look

@sydorovdmytro
Copy link
Contributor Author

Maybe we could merge this one too? 😄

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus merged commit e970061 into emberstack:main Jul 6, 2023
2 checks passed
@sydorovdmytro sydorovdmytro deleted the DS_fix_hpa_spec branch July 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants