Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraEnv and podLabels to helm chart deployment #368

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

byxorna
Copy link
Contributor

@byxorna byxorna commented Aug 1, 2023

What is this?

Adds extraEnv and podLabels as top-level values in the helm chart. This is useful for environments that require specific labels to be added to pods to facilitate log/metrics collection.

Verification

I verified this renders properly by running the following, and verifying the labels and env vars are present and indented correctly.

kubernetes-reflector/src/helm/reflector $ helm template -f <(echo -e 'podLabels: { "foo":"bar" }\nextraEnv: [{name: "TEST", value: "example"}]') reflector ./

@sydorovdmytro

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus merged commit 064e55f into emberstack:main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants