Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace esprima with Babylon #113

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

t-sauer
Copy link
Contributor

@t-sauer t-sauer commented Apr 24, 2018

Babylon recently added the ability to parse TypeScript files. So changing to Babylon enables us to parse TS and JS files with the same logic which should make it easier in the future to add the features of the language server for TypeScript projects.

Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! you might want to update the PR message though to explain why you're doing this change 😉

@t-sauer t-sauer merged commit 40a4baf into ember-tooling:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants