Skip to content

Commit

Permalink
up to 2.0.8
Browse files Browse the repository at this point in the history
  • Loading branch information
Steven Diamond committed Oct 21, 2020
1 parent 40eb28e commit 97db46b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ecos
Submodule ecos updated 5 files
+1 −1 .bumpversion.cfg
+3 −1 .gitignore
+137 −0 CMakeLists.txt
+1 −1 include/ecos.h
+28 −9 src/ecos.c

12 comments on commit 97db46b

@h-vetinari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveDiamond, will you make a release for 2.0.8 some time?

@SteveDiamond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hesitant to update the version number, because the CI is triggered on that but also super broken. I tried fixing the CI but it was too complicated. Can you pin to a commit?

@h-vetinari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we need to fix the CI first 😉
Based on the most recent PR, there does not seem to be any CI for PRs? That would probably be the first step...

@SteveDiamond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really about it not being run on PRs, but that the CI literally doesn't work any more. I tried to fix it on this branch: https://github.com/embotech/ecos-python/tree/build
but had to give up.

@h-vetinari
Copy link

@h-vetinari h-vetinari commented on 97db46b Jan 13, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's annoying for sure, but IMO, it needs to be re-setup or this project is basically dead. I'd be willing to help debug a bit, but AFAIK PR-integration (with whatever CI provider) can only be set up on the main branches directly.

(I mean, it's possible to run the CI for a given commit in the conda-forge feedstock, but that'd be really just a stopgap.)

@SteveDiamond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-vetinari the main developer Eric Chu, has fixed the CI and put out a 2.0.8 release.

@h-vetinari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks.

@h-vetinari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit more than 2.5 days since 2.0.8 was released, but the packages haven't reached PyPI yet. Is this still planned?

@SteveDiamond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echu should 2.0.8 be deployed to pypi by the CI?

@echu
Copy link
Collaborator

@echu echu commented on 97db46b Jan 19, 2021 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-vetinari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey all

just checking in again regarding the wheels on PyPI... 🙃

@georgevreilly-stripe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload the 2.0.8 wheels to PyPI. Thanks.

Please sign in to comment.