-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use semantic convention constants #964
Use semantic convention constants #964
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## use-semantic-conventions #964 +/- ##
============================================================
- Coverage 80.91% 80.91% -0.01%
============================================================
Files 445 443 -2
Lines 11827 11790 -37
Branches 1806 1802 -4
============================================================
- Hits 9570 9540 -30
+ Misses 1462 1459 -3
+ Partials 795 791 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Yeah, those keys are not used by us and in fact the resource object isn't even sent to our backend via the envelope. We probably should though - the resource
object in the payload envelope should be a superset of this.
The reason this wasn't done was because the the attribute naming. Our backend doesn't like the .
in the key names, so we never merged the two. There's an outstanding item to resolve this that we were going to do after we shipped our first version.... which is now.
More details about this here: https://www.notion.so/embraceio/How-do-we-name-payload-envelope-fields-that-are-also-OTel-attributes-and-resources-given-the-conflic-4e8bc1ea3a4c457c9243774ada475c90?pvs=4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use further semantic convention constants
Goal
Replaces existing OTel semantic convention keys with the constants defined in the semantic convention dependency.
Note: as part of this I noticed that
os.model.identifier
andos.model.name
were mistakenly set as a resource value - they should have been prefixed withdevice
. I've chosen to fix this as I believe it will only affect OTel export & doesn't need changes on our backend.Testing
Relied on existing test coverage.