Refactor how span status is peristed and sent to sdk span from wrappers #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Set the status and status description on the SDK span when
setStatus()
is called fromEmbSpan
. We still won't set it to OK whenEmbraceSpan.end()
is called without an ErrorCode, as this value is not useful when using the Embrace API. When anErrorCode
is used, we set the status to ERROR automatically.Testing
Fix up existing tests.