Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how span status is peristed and sent to sdk span from wrappers #967

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jun 14, 2024

Goal

Set the status and status description on the SDK span when setStatus() is called from EmbSpan. We still won't set it to OK when EmbraceSpan.end() is called without an ErrorCode, as this value is not useful when using the Embrace API. When an ErrorCode is used, we set the status to ERROR automatically.

Testing

Fix up existing tests.

Copy link
Collaborator Author

bidetofevil commented Jun 14, 2024

@bidetofevil bidetofevil marked this pull request as ready for review June 15, 2024 05:53
@bidetofevil bidetofevil requested a review from a team as a code owner June 15, 2024 05:53
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team June 15, 2024 05:53
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (070a69a) to head (1eed8f4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   80.94%   80.96%   +0.01%     
==========================================
  Files         444      444              
  Lines       11824    11814      -10     
  Branches     1807     1805       -2     
==========================================
- Hits         9571     9565       -6     
+ Misses       1458     1456       -2     
+ Partials      795      793       -2     
Files Coverage Δ
.../android/embracesdk/internal/payload/SpanMapper.kt 62.00% <100.00%> (-0.97%) ⬇️
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 85.45% <100.00%> (+0.70%) ⬆️
...mbrace/android/embracesdk/opentelemetry/EmbSpan.kt 96.15% <100.00%> (+4.48%) ⬆️
...android/embracesdk/spans/PersistableEmbraceSpan.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 86.56% <90.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

Base automatically changed from hho/span-status-setting to master June 17, 2024 21:34
@bidetofevil bidetofevil merged commit 6ffaaa1 into master Jun 18, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/refactor-span-status branch June 18, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants