Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #968

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix flaky test #968

merged 1 commit into from
Jun 17, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

EmbraceCacheServiceConcurrentAccessTest started failing sporadically because the TestPlatformSerializer did not override all serializer functions. The serialization code was recently changed to use a different function signature & therefore execution wasn't paused, resulting in a race condition that failed some assertions.

I ran this test case ~10 times locally to verify it now passes & also avoided inheritance by delegation to ensure this problem is more obvious if it ever happens in future.

@fractalwrench fractalwrench requested a review from a team as a code owner June 17, 2024 13:38
@fractalwrench fractalwrench changed the title test: fix flaky test Fix flaky test Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (2541327) to head (9a2bcdc).
Report is 1 commits behind head on integration/v2-migration.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           integration/v2-migration     #968      +/-   ##
============================================================
+ Coverage                     79.69%   79.71%   +0.01%     
============================================================
  Files                           407      407              
  Lines                         10826    10826              
  Branches                       1720     1720              
============================================================
+ Hits                           8628     8630       +2     
+ Misses                         1419     1417       -2     
  Partials                        779      779              

see 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Of course! Thanks for fixing this!

@fractalwrench fractalwrench merged commit f60caf6 into integration/v2-migration Jun 17, 2024
3 checks passed
@fractalwrench fractalwrench deleted the fix-flaky-test branch June 17, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants