Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
EmbraceCacheServiceConcurrentAccessTest
started failing sporadically because theTestPlatformSerializer
did not override all serializer functions. The serialization code was recently changed to use a different function signature & therefore execution wasn't paused, resulting in a race condition that failed some assertions.I ran this test case ~10 times locally to verify it now passes & also avoided inheritance by delegation to ensure this problem is more obvious if it ever happens in future.