Prevent lateinit property exception #969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
NetworkConnectivityService
registers for network changes during its initialization. As this service has a bootstrapped reference to theDataSourceModule
which is initialized after it, in rare circumstances where startup is slow + a network connectivity change happens this could result in access to a lateinit var that isn't initialized, which was captured as an internal error.I've fixed this by ensuring that connectivity change registration only happens after the
DataSourceModule
is initialized.