Add limit for internal span capture #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidetofevil
reviewed
Jun 19, 2024
| @@ -140,6 +140,7 @@ internal class SpanServiceImpl( | |||
| } | |||
|
|
|||
| companion object { | |||
| const val MAX_INTERNAL_SPANS_PER_SESSION = 1000 | |||
There was a problem hiding this comment.
I think we should bump this limit - network requests will easily push past this, and we allow 1000 per session per domain, IIRC. I'd go 3000 to start off with, and maybe look at existing data to inform this limit?
There was a problem hiding this comment.
Good point. I bumped this to 5000 & we can adjust from there. Really it's just a backstop to avoid stupid amounts of spans getting logged & in practice I don't think this will be reached for the vast majority of payloads
bidetofevil
approved these changes
Jun 19, 2024
fractalwrench
force-pushed
the
add-internal-span-limit
branch
from
405f79d
to
2fecce9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## integration/v2-migration #974 +/- ##
=========================================================
Coverage 79.78% 79.78%
=========================================================
Files 406 406
Lines 10798 10804 +6
Branches 1715 1716 +1
=========================================================
+ Hits 8615 8620 +5
Misses 1406 1406
- Partials 777 778 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds a limit of 1000 for the number of internal spans that we capture. I'm open to discussion on the exact limit we enforce, but noticed during my validation of this migration that the number of internal spans was unbounded.
Technically we should always bound the number of spans in the
DataSourceimplementation, but in practice I'd like to add this as a backstop to prevent the payload from getting overloaded.Testing
Added unit tests.