Avoid dropping sessions #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidetofevil
reviewed
Jun 19, 2024
| @@ -41,6 +41,7 @@ internal data class Envelope<T>( | |||
|
|
|||
| internal fun Envelope<SessionPayload>.getSessionSpan(): Span? { | |||
| return data.spans?.singleOrNull { it.hasFixedAttribute(EmbType.Ux.Session) } | |||
| ?: data.spanSnapshots?.singleOrNull { it.hasFixedAttribute(EmbType.Ux.Session) } | |||
There was a problem hiding this comment.
Oh yeah this would be a thing
fractalwrench
changed the base branch from
integration/v2-migration
to
add-internal-span-limit
fractalwrench
force-pushed
the
fix-session-sending
branch
from
643ecf4
to
e822d58
Compare
fractalwrench
force-pushed
the
fix-session-sending
branch
from
e822d58
to
b27dab6
Compare
Base automatically changed from
add-internal-span-limit
to
integration/v2-migration
June 20, 2024 07:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolves an issue with the integration branch where sessions weren't persisted to disk as the session ID couldn't be found in the payload. The fix is to look first in the
spansfield, and then in thespan_snapshotsfield for the session span.I've also improved the error messaging around failed HTTP requests as it was initially very hard to tell that a 400 status code was received by the server. Finally, I've tweaked the
typevalue tospansas this seems to be what the mock api expects, although the field is unused by the actual implementation at this time.