Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bazel support #403

Closed
wants to merge 1 commit into from
Closed

Conversation

Vertexwahn
Copy link
Contributor

This PR helps users of the Bazel build system to integrate Embree in their builds.

Supporting two build systems (CMake and Bazel) is more effort to maintain but helps spread Embree.
In the worst case the Bazel build does simply not work - in the best case, someone who uses Bazel can benefit from it.

Also, other projects support CMake and Bazel side by side (e.g. Catch2, GoogleTest, oneTBB, https://github.com/AcademySoftwareFoundation/openexr, etc.).

I am willing to support the Bazel build support of Embree at least for a half year - after this period I can reconsider doing it for another half year

@Vertexwahn
Copy link
Contributor Author

@svenwoop Can you have a look?

@svenwoop
Copy link
Contributor

We discussed this internally and we do not want to add other build systems other than cmake to Embree.

@svenwoop svenwoop closed this Sep 20, 2022
@Vertexwahn
Copy link
Contributor Author

Finally, I came up now with rules_embree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants