Add js/rust bindings for inline source map generation #62
Conversation
|
Thanks. I think the suggestion of changing to an options object and accepting a breaking change is good, please update to that version. |
|
@ef4 this is my first time reading and writting rust so I gave it my best shot, as far as I could tell it doesn't support to have an optional object as an argument in rust, so I took care of that in js space and made sure to always provide all arguments with defaults to the function we get back from wasm. As I don't have knowledge of rust code maybe there was a simpler solution, but this was the best I could do w/o spending weeks learning rust and wasm :) Let me know if you have any feedback |
| @@ -35,6 +35,7 @@ lazy_static = "1.4.0" | |||
| base64 = "0.21.4" | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| serde-wasm-bindgen = "0.4" | |||
There was a problem hiding this comment.
I use it's from_value function to parse the object argument here
There was a problem hiding this comment.
is it a successor to regular wasm-bindgen? or are the non-serde deps just on their way out anyway?
There was a problem hiding this comment.
I got this from the docs, that's why I used it https://docs.rs/serde-wasm-bindgen/latest/serde_wasm_bindgen/.
There was a problem hiding this comment.
tbh I didn't really have time to learn wasm or rust enough to properly understand what I was doing
There was a problem hiding this comment.
oooo that's nice, thanks for providing that info!
| @@ -173,7 +173,7 @@ describe(`parse`, function () { | |||
| p.process( | |||
| `const thing = "face"; | |||
| <template>Hi`, | |||
| "path/to/my/component.gjs", | |||
There was a problem hiding this comment.
is the old way still able to be supported?
There was a problem hiding this comment.
Upthread I said a breaking change is OK, so I don't think we should keep the old way. It's a very easy upgrade.
|
@ef4 does it look good to you, can this get merged/released? |
Fixes #61
Right now I just added an extra argument to make it a non-braking change, but if you feel like we want to have second argument be an object that accepts the
filename: stringandinput_source_maps: boolI can also change it to that