Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.2+ broken due to missing @babel/traverse #580

Closed
runspired opened this issue May 6, 2023 · 3 comments
Closed

Release 2.6.2+ broken due to missing @babel/traverse #580

runspired opened this issue May 6, 2023 · 3 comments

Comments

@runspired
Copy link

runspired commented May 6, 2023

This may be a peer-dep installation issue or a peer-dep needing to be declared, as in CI (but not locally) we see this: babel-plugin-ember-template-compilation/src/node-main.js)Error: [BABEL]: Cannot find module '@babel/traverse'

tests/request test: - /home/runner/work/data/data/node_modules/.pnpm/broccoli-babel-transpiler@7.8.1/node_modules/broccoli-babel-transpiler/lib/worker.js (While processing: /home/runner/work/data/data/node_modules/.pnpm/babel-plugin-ember-template-compilation@2.0.2/node_modules/babel-plugin-ember-template-compilation/src/node-main.js)Error: [BABEL]: Cannot find module '@babel/traverse'

After isolating various in-flight dependency bumps, we see the only bump that causes this is that of ember-auto-import from 2.6.1

The lockfile diff contains very few changes other than the ember-auto-import version change:

This one stands out as an addition of a previously non-existent dependency

 /babel-plugin-ember-template-compilation@2.0.3:
    resolution: {integrity: sha512-SIetZD/uCLnzIBTJtzYGc2Q55TPqM5WyjuOgW+Is1W3SZVljlY3JD5Add29hDMs//OvXBWoXfOopQxkfG4/pIA==}
    engines: {node: '>= 12.*'}
    dependencies:
      babel-import-util: 1.3.0
@NullVoxPopuli
Copy link
Contributor

Hello! thanks for reporting!
Can you provide a repro repo?

@runspired
Copy link
Author

runspired commented Jul 6, 2023

EmberData. Every drifting dep test run fails this way, or bump anything related to ember-auto-import locally and observe failure. PR in which all hell breaks loose emberjs/data#8679

@runspired runspired changed the title Release 2.6.2 / 2.6.3 causing builds to hang Release 2.6.2+ broken in various mysterious ways Jul 6, 2023
@runspired runspired changed the title Release 2.6.2+ broken in various mysterious ways Release 2.6.2+ broken due to missing @babel/traverse Jul 6, 2023
@runspired
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants