Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @babel/traverse is a dependency not a dev-dependency #24

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jul 6, 2023

I think this is what is needed to resolve #23. Not able to test this via pnpm patch as apparently package.json dependencies can't be fixed that way. Setting pnpm up like the following which mirrors this change did work:

 "packageExtensions": {
      "babel-plugin-ember-template-compilation": {
        "dependencies": {
          "@babel/traverse": "^7.14.5"
        }
      }

Copy link
Sponsor Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ef4
Copy link
Contributor

ef4 commented Jul 7, 2023

Thanks. This got missed because it was originally only used for type imports, but then we added one real implementation import.

@ef4 ef4 merged commit 9159266 into emberjs:main Jul 7, 2023
4 checks passed
@ef4
Copy link
Contributor

ef4 commented Jul 7, 2023

Followed up with #25 because we never should have depended directly on traverse in the first place.

@ef4 ef4 added the bug Something isn't working label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.3 Errors with missing @babel/traverse
3 participants