Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESBuild for minification #467

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@NullVoxPopuli
Copy link
Contributor Author

from $ TAILWIND_MODE=build ember build --environment=production(very small app, one route)
Before

37.41s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.6080b23d1b1d69f38f9d.js: 228.25 KB (65.35 KB gzipped)
 - dist/assets/chunk.d60415d57fdc996ec57e.js: 21.36 KB (5.88 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 37.41s.
29.94s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.6080b23d1b1d69f38f9d.js: 228.25 KB (65.35 KB gzipped)
 - dist/assets/chunk.d60415d57fdc996ec57e.js: 21.36 KB (5.88 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 29.94s.
28.96s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.6080b23d1b1d69f38f9d.js: 228.25 KB (65.35 KB gzipped)
 - dist/assets/chunk.d60415d57fdc996ec57e.js: 21.36 KB (5.88 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 28.96s.

After

31.36s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.12a678c236ec95652eaf.js: 228.26 KB (65.38 KB gzipped)
 - dist/assets/chunk.fc75b1bce77fa34e23db.js: 21.38 KB (5.91 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 31.36s.
24.49s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.12a678c236ec95652eaf.js: 228.26 KB (65.38 KB gzipped)
 - dist/assets/chunk.fc75b1bce77fa34e23db.js: 21.38 KB (5.91 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 24.49s.
23.95s
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/chunk.12a678c236ec95652eaf.js: 228.26 KB (65.38 KB gzipped)
 - dist/assets/chunk.fc75b1bce77fa34e23db.js: 21.38 KB (5.91 KB gzipped)
 - dist/assets/liquidity-pools.css: 19.85 KB (5.97 KB gzipped)
 - dist/assets/liquidity-pools.df130710659cecda30fe725a093d2ae6.css: 9.28 KB (2.64 KB gzipped)
 - dist/assets/vendor.39fa57c8e0a2b054e888e4caae13742a.js: 1.66 MB (567.63 KB gzipped)
 - dist/assets/vendor.47e5b13a6c66903c00db8ae984063008.css: 5.9 KB (1.4 KB gzipped)
Done in 23.95s.

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Nov 4, 2021

Bigger app: https://github.com/ember-learn/ember-website

time ember build --environment=production

results pending... having issues 🙃

@NullVoxPopuli
Copy link
Contributor Author

I think I've determined this has no effect.
And any difference in results are due to my test machine being unstable (and too few data points).

@ef4, it seems that no matter what ember-auto-import generates, it's ran through broccoli-terser-sourcemap, which means we can close this PR in favor of: ember-cli/ember-cli#9693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant