feat(new app-boot): replace app-boot.js with an in-html module

embroider-build · Jun 13, 2024 · c1a76b7 · c1a76b7
1 parent 348291d
commit c1a76b7
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 19 deletions.
diff --git a/tests/addon-template/tests/dummy/app/app-boot.js b/tests/addon-template/tests/dummy/app/app-boot.js
diff --git a/tests/addon-template/tests/dummy/app/index.html b/tests/addon-template/tests/dummy/app/index.html
@@ -17,7 +17,12 @@
     {{content-for "body"}}
 
     <script src="/@embroider/core/vendor.js"></script>
-    <script src="/app-boot.js" type="module"></script>
+    <script type="module">
+      import Application from './app';
+      import environment from './config/environment';
+
+      Application.create(environment.APP);
+    </script>
 
     {{content-for "body-footer"}}
   </body>

diff --git a/tests/addon-template/tests/index.html b/tests/addon-template/tests/index.html
@@ -30,7 +30,6 @@
     <script src="/testem.js" integrity="" data-embroider-ignore></script>
     <script src="/@embroider/core/vendor.js"></script>
     <script src="/@embroider/core/test-support.js"></script>
-    <script src="/app-boot.js" type="module"></script>
     <script src="/@embroider/core/test-entrypoint" type="module"></script>
 
     {{content-for "body-footer"}}

diff --git a/tests/app-template/app/app-boot.js b/tests/app-template/app/app-boot.js
diff --git a/tests/app-template/app/index.html b/tests/app-template/app/index.html
@@ -17,7 +17,12 @@
     {{content-for "body"}}
 
     <script src="/@embroider/core/vendor.js"></script>
-    <script src="/app-boot.js" type="module"></script>
+    <script type="module">
+      import Application from './app';
+      import environment from './config/environment';
+
+      Application.create(environment.APP);
+    </script>
 
     {{content-for "body-footer"}}
   </body>

diff --git a/tests/app-template/tests/index.html b/tests/app-template/tests/index.html
@@ -27,7 +27,6 @@
     <script src="/testem.js" integrity="" data-embroider-ignore></script>
     <script src="/@embroider/core/vendor.js"></script>
     <script src="/@embroider/core/test-support.js"></script>
-    <script src="/app-boot.js" type="module"></script>
     <script src="/@embroider/core/test-entrypoint" type="module"></script>
 
     {{content-for "body-footer"}} {{content-for "test-body-footer"}}

diff --git a/tests/fixtures/macro-test/tests/index.html b/tests/fixtures/macro-test/tests/index.html
@@ -36,7 +36,6 @@
     <script src="{{rootURL}}apple.js"></script>
     <script src="{{rootURL}}ordered.js"></script>
     <script src="/@embroider/core/test-support.js"></script>
-    <script src="/app-boot.js" type="module"></script>
     <script src="/@embroider/core/test-entrypoint" type="module"></script>
 
     {{content-for "body-footer"}}

diff --git a/tests/ts-app-template/app/app-boot.js b/tests/ts-app-template/app/app-boot.js
diff --git a/tests/ts-app-template/app/index.html b/tests/ts-app-template/app/index.html
@@ -17,7 +17,12 @@
     {{content-for "body"}}
 
     <script src="/@embroider/core/vendor.js"></script>
-    <script src="/app-boot.js" type="module"></script>
+    <script type="module">
+      import Application from './app';
+      import environment from './config/environment';
+
+      Application.create(environment.APP);
+    </script>
 
     {{content-for "body-footer"}}
   </body>

diff --git a/tests/ts-app-template/tests/index.html b/tests/ts-app-template/tests/index.html
@@ -30,7 +30,6 @@
     <script src="/testem.js" integrity="" data-embroider-ignore></script>
     <script src="/@embroider/core/vendor.js"></script>
     <script src="/@embroider/core/test-support.js"></script>
-    <script src="/app-boot.js" type="module"></script>
     <script src="/@embroider/core/test-entrypoint" type="module"></script>
 
     {{content-for "body-footer"}}