Merge pull request #1029 from Windvis/fix/component-helper-resolver-i…

…gnore-built-ins Don't resolve built-in components when used with the component helper
embroider-build · Dec 7, 2021 · c880396 · c880396
2 parents 6343e9c + b4c3b10
commit c880396
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/packages/compat/src/resolver.ts b/packages/compat/src/resolver.ts
@@ -802,6 +802,11 @@ export default class CompatResolver implements Resolver {
         from
       );
     }
+
+    if (builtInComponents.includes(component.path)) {
+      return null;
+    }
+
     let found = this.tryComponent(component.path, from);
     if (found) {
       return this.add(found, from);

diff --git a/packages/compat/tests/resolver.test.ts b/packages/compat/tests/resolver.test.ts
@@ -518,6 +518,21 @@ describe('compat-resolver', function () {
       },
     ]);
   });
+  test('built-in components are ignored when used with the component helper', function () {
+    let findDependencies = configure({
+      staticComponents: true,
+    });
+    expect(
+      findDependencies(
+        'templates/application.hbs',
+        `
+      {{component "input"}}
+      {{component "link-to"}}
+      {{component "textarea"}}
+    `
+      )
+    ).toEqual([]);
+  });
   test('component helper with direct addon package reference', function () {
     let findDependencies = configure({
       staticComponents: true,