Can't resolve ./-computed-store in ...ember-macro-helpers #285

ChristopherConnock · 2019-07-16T22:01:35Z

Building on Windows 10 with Ember 3.11.

I am getting the following error with ember-macro-helpers. I tried forcing the use of the latest build (4.2.0) to no avail. It is used in ember-moment and ember-awesome-macros.

ERROR Summary:

broccoliBuilderErrorStack: ModuleNotFoundError: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
at factory.create (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\Compilation.js:821:10)
at factory (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:397:22)
at resolver (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:130:21)
at asyncLib.parallel (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:224:22)
at C:\Users\511\Documents\GitHub\roast-ember\node_modules\neo-async\async.js:2830:7
at C:\Users\511\Documents\GitHub\roast-ember\node_modules\neo-async\async.js:6877:13
at normalResolver.resolve (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:214:25)
at doResolve (C:\Users\511\Documents\GitHub\roast-ember\node_modules\enhanced-resolve\lib\Resolver.js:184:12)
at hook.callAsync (C:\Users\511\Documents\GitHub\roast-ember\node_modules\enhanced-resolve\lib\Resolver.js:238:5)
at _fn0 (eval at create (C:\Users\511\Documents\GitHub\roast-ember\node_modules\tapable\lib\HookCodeFactory.js:33:10), :15:1)
code: [undefined]
codeFrame: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
errorMessage: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
at PackagerRunner (@embroider/webpack)
-~~- created here: -~~-
at new Plugin (C:\Users\511\Documents\GitHub\roast-ember\node_modules\broccoli-plugin\index.js:7:31)
at new PackagerRunner (C:\Users\511\Documents\GitHub\roast-ember\node_modules@embroider\core\src\to-broccoli-plugin.js:10:13)
at Object.defaultPipeline [as compatBuild] (C:\Users\511\Documents\GitHub\roast-ember\node_modules@embroider\compat\src\default-pipeline.js:30:12)
at module.exports (C:\Users\511\Documents\GitHub\roast-ember\ember-cli-build.js:54:39)
at Builder.readBuildFile (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:51:14)
at Builder.setupBroccoliBuilder (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:65:22)
at new Builder (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:31:10)
at ServeTask.run (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\tasks\serve.js:49:7)
at Promise.resolve.then (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\command.js:239:24)
at tryCatcher (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\node_modules\rsvp\dist\rsvp.js:326:21)
-~~- (end) -~~-
errorType: Build Error
location:
- column: [undefined]
- file: [undefined]
- line: [undefined]
- treeDir: [undefined]
message: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
at PackagerRunner (@embroider/webpack)
-~~- created here: -~~-
at new Plugin (C:\Users\511\Documents\GitHub\roast-ember\node_modules\broccoli-plugin\index.js:7:31)
at new PackagerRunner (C:\Users\511\Documents\GitHub\roast-ember\node_modules@embroider\core\src\to-broccoli-plugin.js:10:13)
at Object.defaultPipeline [as compatBuild] (C:\Users\511\Documents\GitHub\roast-ember\node_modules@embroider\compat\src\default-pipeline.js:30:12)
at module.exports (C:\Users\511\Documents\GitHub\roast-ember\ember-cli-build.js:54:39)
at Builder.readBuildFile (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:51:14)
at Builder.setupBroccoliBuilder (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:65:22)
at new Builder (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\builder.js:31:10)
at ServeTask.run (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\tasks\serve.js:49:7)
at Promise.resolve.then (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\lib\models\command.js:239:24)
at tryCatcher (C:\Users\511\Documents\GitHub\roast-ember\node_modules\ember-cli\node_modules\rsvp\dist\rsvp.js:326:21)
-~~- (end) -~~-
name: BuildError
nodeAnnotation: @embroider/webpack
nodeName: PackagerRunner
originalErrorMessage: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
stack: ModuleNotFoundError: Module not found: Error: Can't resolve './-computed-store' in 'C:\Users\511\AppData\Local\Temp\embroider\8f2d44\node_modules\ember-macro-helpers'
at factory.create (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\Compilation.js:821:10)
at factory (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:397:22)
at resolver (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:130:21)
at asyncLib.parallel (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:224:22)
at C:\Users\511\Documents\GitHub\roast-ember\node_modules\neo-async\async.js:2830:7
at C:\Users\511\Documents\GitHub\roast-ember\node_modules\neo-async\async.js:6877:13
at normalResolver.resolve (C:\Users\511\Documents\GitHub\roast-ember\node_modules\webpack\lib\NormalModuleFactory.js:214:25)
at doResolve (C:\Users\511\Documents\GitHub\roast-ember\node_modules\enhanced-resolve\lib\Resolver.js:184:12)
at hook.callAsync (C:\Users\511\Documents\GitHub\roast-ember\node_modules\enhanced-resolve\lib\Resolver.js:238:5)
at _fn0 (eval at create (C:\Users\511\Documents\GitHub\roast-ember\node_modules\tapable\lib\HookCodeFactory.js:33:10), :15:1)

=================================================================================

scottkidder · 2019-07-23T12:18:01Z

I can confirm this on Linux on ember-cli@3.10.1 as well.

It seems to be caused by ember-macro-helpers not having a file at ./-computed-store and instead providing -computed-store by doing a monkey patch here

This change was introduced recently.

Is there configuration in embroider to ignore or workaround this type of situation?

void-mAlex · 2020-02-07T23:57:32Z

Ran into this as well running ember-cli@3.15.2 linux
Any workarounds?

ef4 · 2020-02-08T00:05:37Z

I think this is fixed on master.

…

On Fri, Feb 7, 2020 at 6:57 PM Alex ***@***.***> wrote: Ran into this as well running ***@***.*** linux Any workarounds? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#285?email_source=notifications&email_token=AACN6MXO3CEX7EMVKLFLLXTRBXYO3A5CNFSM4IEINJK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFAPSA#issuecomment-583665608>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACN6MW4CJ4PQWCS2QMJDFTRBXYO3ANCNFSM4IEINJKQ> .

void-mAlex · 2020-02-08T13:37:53Z

thank you for the quick response
I've followed to CONTRIBUTING steps to compile and try out master and I can confirm the build now completes and assets get generated but the whole app no longer functions
I've seen these warnings for the build:

WARNING in ./node_modules/ember-data/adapters/errors.js 1:0-213
"export 'AdapterError' was not found in '@ember-data/adapter/error'
 @ ./assets/blog.js

WARNING in ./helpers/not-eq.js 1:0-87
"export 'notEq' was not found in '../node_modules/ember-truth-helpers/helpers/not-equal'
 @ ./assets/blog.js

WARNING in ./helpers/responsive-image-resolve.js 1:0-122
"export 'responsiveImageResolve' was not found in '../node_modules/ember-responsive-image/helpers/responsive-image-resolve'
 @ ./assets/blog.js

WARNING in ./helpers/route-is.js 1:0-81
"export 'routeIs' was not found in '../node_modules/empress-blog/helpers/route-is'
 @ ./assets/blog.js

WARNING in ./helpers/utc.js 1:0-114
"export 'utc' was not found in '../node_modules/empress-blog-casper-template/node_modules/ember-moment/helpers/utc'
 @ ./assets/blog.js

should I raise this as a separate issue? for some other quick info that might be relevant it's a blog app using empress prember and a default template

ef4 · 2020-02-08T14:04:51Z

This warnings are generally harmless but they’re all real bugs in the addons they’re talking about. These addons try to reexport nonexistent things. It would be helpful for someone to send PRs that clean these up so people stop seeing the warnings.

…

On Sat, Feb 8, 2020 at 8:37 AM Alex ***@***.***> wrote: thank you for the quick response I've followed to CONTRIBUTING steps to compile and try out master and I can confirm the build now completes and assets get generated but the whole app no longer functions I've seen these warnings for the build: WARNING in ./node_modules/ember-data/adapters/errors.js 1:0-213 "export 'AdapterError' was not found in ***@***.***/adapter/error' @ ./assets/blog.js WARNING in ./helpers/not-eq.js 1:0-87 "export 'notEq' was not found in '../node_modules/ember-truth-helpers/helpers/not-equal' @ ./assets/blog.js WARNING in ./helpers/responsive-image-resolve.js 1:0-122 "export 'responsiveImageResolve' was not found in '../node_modules/ember-responsive-image/helpers/responsive-image-resolve' @ ./assets/blog.js WARNING in ./helpers/route-is.js 1:0-81 "export 'routeIs' was not found in '../node_modules/empress-blog/helpers/route-is' @ ./assets/blog.js WARNING in ./helpers/utc.js 1:0-114 "export 'utc' was not found in '../node_modules/empress-blog-casper-template/node_modules/ember-moment/helpers/utc' @ ./assets/blog.js should I raise this as a separate issue? for some other quick info that might be relevant it's a blog app using empress prember and a default template — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#285?email_source=notifications&email_token=AACN6MQS7F5FEFICCYP2AZ3RB2YTDA5CNFSM4IEINJK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFR76A#issuecomment-583737336>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACN6MXK7K4GNMWJ33ZBKM3RB2YTDANCNFSM4IEINJKQ> .

void-mAlex · 2020-02-26T08:38:39Z

#381 fixed this for me

Windvis · 2022-04-29T07:42:56Z

Closing since the original issue seems to be fixed.

scottkidder mentioned this issue Jul 23, 2019

-computed-store monkey patch breaks embroider build kellyselden/ember-macro-helpers#279

Closed

Windvis closed this as completed Apr 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't resolve ./-computed-store in ...ember-macro-helpers #285

Can't resolve ./-computed-store in ...ember-macro-helpers #285

ChristopherConnock commented Jul 16, 2019

scottkidder commented Jul 23, 2019 •

edited

Loading

void-mAlex commented Feb 7, 2020

ef4 commented Feb 8, 2020 via email

void-mAlex commented Feb 8, 2020

ef4 commented Feb 8, 2020 via email

void-mAlex commented Feb 26, 2020

Windvis commented Apr 29, 2022

Can't resolve ./-computed-store in ...ember-macro-helpers #285

Can't resolve ./-computed-store in ...ember-macro-helpers #285

Comments

ChristopherConnock commented Jul 16, 2019

scottkidder commented Jul 23, 2019 • edited Loading

void-mAlex commented Feb 7, 2020

ef4 commented Feb 8, 2020 via email

void-mAlex commented Feb 8, 2020

ef4 commented Feb 8, 2020 via email

void-mAlex commented Feb 26, 2020

Windvis commented Apr 29, 2022

scottkidder commented Jul 23, 2019 •

edited

Loading