Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@embroider/util] Invalid dependency on broccoli-funnel #764

Closed
chriseppstein opened this issue Apr 13, 2021 · 2 comments · Fixed by #766
Closed

[@embroider/util] Invalid dependency on broccoli-funnel #764

chriseppstein opened this issue Apr 13, 2021 · 2 comments · Fixed by #766

Comments

@chriseppstein
Copy link

https://github.com/embroider-build/embroider/blob/master/packages/util/package.json#L32

This dependency spec isn't pointing to released software but is included in the released version of @embroider/util at version 0.39.1.

This causes issues importing software into LinkedIn's artifact cache but I suspect it will cause other issues as well.

@ef4
Copy link
Contributor

ef4 commented Apr 14, 2021

I'm glad LinkedIn wants to fix this because LinkedIn broke it. 😝

Specifically, the refactor that happened in broccoli-funnel 3.0 broke this behavior that embroider relies on. I already found and fixed another serious bug in that release.

And I couldn't stay on 2.x because 2.x depends on an old walk-sync with a critical bug that is fixed in the walk-sync version used by broccoli-funnel 3.0.

Please get broccoli-funnel 3.x fixed and I will gladly switch back to a published version.

@chriseppstein
Copy link
Author

@ef4 I'm just here to let you know that embroider releases can no longer be consumed by linkedin because of this issue. If you were to publish your forked code under a released package e.g. @ef4/broccoli-funnel then it would allow embroider releases to be consumed again. I'll ping @rwjblue about this issue in hopes that we can find a fast resolution. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants