Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-canary packages/utils appears to be failing #932

Closed
stefanpenner opened this issue Aug 23, 2021 · 5 comments · Fixed by #933
Closed

ember-canary packages/utils appears to be failing #932

stefanpenner opened this issue Aug 23, 2021 · 5 comments · Fixed by #933
Assignees

Comments

@stefanpenner
Copy link
Collaborator

stefanpenner commented Aug 23, 2021

ember-canary in packages/utils appears to be failing:
See https://github.com/embroider-build/embroider/runs/3397677418

not ok 1 Chrome 92.0 - [143 ms] - Integration | Helper | ensure-safe-component: string value
    ---
        actual: >
            null
        stack: >
            TypeError: templateFactory$$1 is not a function
                at Function.create (webpack://dummy/../../node_modules/ember-source/@ember/-internals/glimmer/index.js?:8716:22)
                at FactoryManager.create (webpack://dummy/../../node_modules/ember-source/@ember/-internals/container/index.js?:483:25)
                at Proxy.create (webpack://dummy/../../node_modules/ember-source/@ember/-internals/container/index.js?:262:16)
                at eval (webpack://dummy/../../../../node_modules/@ember/test-helpers/setup-rendering-context.js?:252:35)
        message: >
            Promise rejected before "string value": templateFactory$$1 is not a function
        negative: >
            false

I am starting to investigate now, and I am able to reproduce locally

@stefanpenner stefanpenner self-assigned this Aug 23, 2021
@stefanpenner
Copy link
Collaborator Author

I believe @ember/test-helpers is currently incompatible with ember-canary due to emberjs/ember.js#19680 landing. I suspect emberjs/ember.js#19680 (comment) will need to be added to @ember/test-helpers

@stefanpenner
Copy link
Collaborator Author

possible FIX to @ember/test-helpers -> emberjs/ember-test-helpers#1110

@stefanpenner
Copy link
Collaborator Author

stefanpenner commented Aug 23, 2021

Ok, that fix landed. Unfortunately, there appears to be a new issue, this time during template compilation.

@stefanpenner
Copy link
Collaborator Author

Module build failed (from ../../../../../../../../../../../../Users/spenner/src/embroider-build/embroider/packages/babel-loader-8/index.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) TypeError: $TMPDIR/embroider/cb03bb/node_modules/@ember/test-helpers/setup-rendering-context.js/setup-rendering-context.js: Cannot read property 'visitor' of undefined
    at processResult (/Users/spenner/src/embroider-build/embroider/node_modules/webpack/lib/NormalModule.js:718:12)
    at /Users/spenner/src/embroider-build/embroider/node_modules/webpack/lib/NormalModule.js:827:5
    at /Users/spenner/src/embroider-build/embroider/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /Users/spenner/src/embroider-build/embroider/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/Users/spenner/src/embroider-build/embroider/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /Users/spenner/src/embroider-build/embroider/node_modules/babel-loader/lib/index.js:59:103

@stefanpenner
Copy link
Collaborator Author

I believe I have fixed the next issue as well. Pending CI confirmation.

stefanpenner added a commit that referenced this issue Aug 23, 2021
* [fixes #932] fix ember-canary test scenario

description of problem: emberjs/ember.js#19680 (comment)
fix in @ember/test-helpers: emberjs/ember-test-helpers#1110

* [fixes ember-canary/ember-beta] migrate ember-cli-template-lint -> ember-template-lint

Ember-cli-template-lint is deprecated, and now incompatible with ember 4.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant