Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a rebuild crash in dummy apps on windows #1247

Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix a rebuild crash in dummy apps on windows #1247

merged 1 commit into from
Aug 17, 2022

Commits on Aug 17, 2022

  1. fix a rebuild crash in dummy apps on windows 

    Rebuilds could crash on windows when working with a v1 addon's dummy app.

We already defend against the weird circularity of dummy apps, but the check didn't work on windows.

This has test coverage that will land as part of #1246, because that includes a refactor of the test suite that reveals this problem.
    @ef4
    ef4 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    aebec0a View commit details
    Browse the repository at this point in the history