Make ensureSafeComponent usable with Glint
#1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a peer (and dev) dependency on `@glint/template` for the type of `ensureSafeComponent` to always return a `ComponentLike`, which is what its implementation does from the point of view of a consumer using Glint. This is an optional peer dependency, but should be installed by anyone using TS who wants to use Glint types. Note: This would be a breaking change if our TS support story were stable; in this case it is *part of* making our support story stable.
chriskrycho
force-pushed
the
ensureSafeComponent-types
branch
from
49b0360
to
bafee9c
Compare
|
Thanks, this seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a peer (and dev) dependency on
@glint/templatefor the type ofensureSafeComponentto always return aComponentLike, which is what its implementation does from the point of view of a consumer using Glint. This is an optional peer dependency, but should be installed by anyone using TS who wants to use Glint types.Note: This would be a breaking change if our TS support story were stable; in this case it is part of making our support story stable.