New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable release sync with main #1364
Merged
ef4
merged 6 commits into
embroider-build:main
from
NullVoxPopuli:unstable-release-sync-with-main
Mar 7, 2023
Merged
Unstable release sync with main #1364
ef4
merged 6 commits into
embroider-build:main
from
NullVoxPopuli:unstable-release-sync-with-main
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
unstable-release-sync-with-main
branch
3 times, most recently
from
February 17, 2023 21:31
cb40d9d
to
9effdbd
Compare
NullVoxPopuli
commented
Feb 17, 2023
NullVoxPopuli
commented
Feb 17, 2023
NullVoxPopuli
force-pushed
the
unstable-release-sync-with-main
branch
from
February 17, 2023 21:34
9effdbd
to
7846411
Compare
ef4
reviewed
Feb 20, 2023
NullVoxPopuli
commented
Feb 20, 2023
NullVoxPopuli
force-pushed
the
unstable-release-sync-with-main
branch
from
February 21, 2023 21:26
228a25d
to
6dae7d1
Compare
NullVoxPopuli
force-pushed
the
unstable-release-sync-with-main
branch
from
February 21, 2023 21:31
6dae7d1
to
f110db9
Compare
NullVoxPopuli
commented
Feb 21, 2023
@@ -8959,6 +8959,21 @@ execa@^5.0.0, execa@^5.1.1: | |||
signal-exit "^3.0.3" | |||
strip-final-newline "^2.0.0" | |||
|
|||
execa@^7.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use new enough execa for execCommand / native ESM.
Node 14.18 is supported: https://github.com/sindresorhus/execa/blob/main/package.json#L16
Publishing wasn't really implemented correctly but I fixed it and ran it locally. See the unstable.73213f2a packages on NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Inspired by: https://github.com/ember-animation/ember-animated/blob/master/.github/workflows/publish-unstable.yml
CLI Output:
Sample Diff: