Fix Maximum call stack size exceeded error
#1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was also desirable to give the better error in case the loop comes up for any other scenario, will try both this fix and the change for the error as soon as I get some time |
|
After our discussions yesterday, I'm pretty convinced this is correct. It's consistent with the way we already rewrite v1 addons.
Agreed, stopping the cycle is also good. |
ef4
approved these changes
Mar 29, 2023
This was referenced May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I was running into the same issue that @void-mAlex has reported in yesterday's office hours, and as we discussed it removing the
exportsfrom the rewritten package.json indeed fixes the problem. At least for me, maybe @void-mAlex you can double check that on your side too?