Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prettier in ci #1388

Merged

Conversation

NullVoxPopuli
Copy link
Collaborator

Extracted from: #1384
since the editorconfig tooling may be suspicious (or misconfigured)

Copy link
Collaborator

@void-mAlex void-mAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the motivation to change quotes in template/html files?
as far as I can tell default in ember is double quotes in templates single for js files

package.json Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
@NullVoxPopuli
Copy link
Collaborator Author

what's the motivation to change quotes in template/html files?
as far as I can tell default in ember is double quotes in templates single for js files

I didn't change the prettier config -- this PR only hooks up prettier to C.I. and package.json#scripts. -- if there is a better config to use, lemme know.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discussed this in the meeting

packages/util/tests/dummy/app/templates/application.hbs Outdated Show resolved Hide resolved
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@NullVoxPopuli NullVoxPopuli merged commit a6cd4aa into embroider-build:main Apr 19, 2023
@NullVoxPopuli NullVoxPopuli deleted the enable-prettier-in-ci branch April 19, 2023 02:54
This was referenced May 2, 2023
@ef4 ef4 added the internal label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants