Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running publish-unstable on workflow_dispatch #1392

Conversation

NullVoxPopuli
Copy link
Collaborator

Sometimes the GitHub API fails with Error: 429 Too many Requests. This can happen during the publish-unstable workflow, which isn't great, but we can wait for quota to recover a bit, and re-run the workflow manually.

This is done with the workflow_dispatch trigger, as implemented in this PR.

I've also done this on on my own repo, for syncing a branch that tests the latest unstable release of all the embroider packages.

I first learned about this strategy from: https://dev.to/this-is-learning/manually-trigger-a-github-action-with-workflowdispatch-3mga

Here are the docs on workflow_dispatch
And How to manually run a workflow
image

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need this change 🤔 we discussed this in the meeting and #1393 is the actual fix that we need

@ef4 ef4 merged commit 3a9d8ad into embroider-build:main Apr 11, 2023
179 of 199 checks passed
This was referenced May 2, 2023
@ef4 ef4 added the internal label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants