Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Prep]: Update proposed changelog #1404

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

Automated and continuously updated PR for adding changeset entries for merged PRs.

TODO

  • Determine patch/minor/major impact for each package for each changeset
  • if applicable, mark/remove certain changes as omitted from the changelog
  • if applicable, bundle changes together in to a single "change set"

Remember

  • This PR is updated on every merge to main
  • This PR is force-pushed, so changes should happen on a separate branch

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Apr 25, 2023

TODOs for myself w/r/t this automation:

  • add flag to the tool (and use it in the package.json) to only include changes that belong to packages
  • figure out what happened here (too many packages detected as changed)

Once those two things are dealt with,

  • open a PR to embroider, upgrading the dep

@github-actions github-actions bot force-pushed the sync-changelog branch 3 times, most recently from 423b027 to 61009b5 Compare May 2, 2023 01:53
@ef4
Copy link
Contributor

ef4 commented May 2, 2023

  1. Why --only-prs?

  2. How did you decide what to put in .changeset/.recoverignore? Because I'm seeing stuff in there that's definitely publicly-facing changes.

@NullVoxPopuli NullVoxPopuli mentioned this pull request May 2, 2023
@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented May 2, 2023

Why --only-prs?

It's the only way to get a PR link to GitHub, specifically for attributing work and grabbing the title of the change as well.

How did you decide what to put in .changeset/.recoverignore?

generally things that didn't fit in to any packages (such as .github/ changes)
that said the "what packages changed detection" isn't perfect -- though, I've (so far) only noticed it saying too many packages changed, rather than too few. Need to do another pass on that

Ideally, when that's figured out, a --only-packages flag would mean that we wouldn't need a .recoverignore and the detected changed packages would be more correct (today, a change in one package can flag a change in all packages -- but it's just git diffing, so.. need to look in to that)

@github-actions github-actions bot force-pushed the sync-changelog branch 3 times, most recently from ba1caf6 to 2570629 Compare May 8, 2023 11:25
@github-actions github-actions bot force-pushed the sync-changelog branch 6 times, most recently from 4104d56 to c9b7fb8 Compare May 15, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants