Use a custom changelog line generator function to avoid adding meaningless changelog entries #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
May 2, 2023
| @@ -59,20 +59,19 @@ | |||
| "**/graceful-fs": "^4.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@changesets/changelog-github": "^0.4.7", | |||
NullVoxPopuli
commented
May 2, 2023
| "@changesets/cli": "^2.25.0", | ||
| "@types/jest": "^29.2.0", | ||
| "@typescript-eslint/eslint-plugin": "^4.1.1", | ||
| "@typescript-eslint/parser": "^4.1.1", | ||
| "changeset-recover": "0.1.0-beta.10", |
There was a problem hiding this comment.
using the yarn CLI sorted this file
mansona
approved these changes
May 8, 2023
There was a problem hiding this comment.
I've reviewed this the best I can. Unfortunately I think it's very much in a "let's try it and see" category because it's a bit hard to predict what this will do without having a lot of context into changesets.
Fortunately it's a non-destructive process so there is little lost from just merging it and seeing what happens on the next update 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Release Preview PR: #1408
We have a bunch of commits that are duplicated:
This is because
changesetsis using the commit that thechangesetfile was added, rather than the commit of the actual change.There are two problems:
This PR addresses both of those things.
Preview:
This uses a tweaked version of the changelog-git plugin: https://github.com/changesets/changesets/blob/main/packages/changelog-git/src/index.ts