Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkto routable engine path in host app #1443

Merged
merged 12 commits into from May 30, 2023
Merged

linkto routable engine path in host app #1443

merged 12 commits into from May 30, 2023

Conversation

void-mAlex
Copy link
Collaborator

this pr adds a failing test case for routable lazy engines

@void-mAlex void-mAlex marked this pull request as ready for review May 23, 2023 15:05
void-mAlex
void-mAlex commented May 30, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mansona
mansona approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with what I see in this PR 👍 the only thing I'm not sure about is the use_lockfile: true change. I understand the reasoning for the change and I'm happy to merge it, I just want us to be clear on a longer-term strategy as a team i.e. next steps

@void-mAlex
Copy link
Collaborator Author

I'm happy with what I see in this PR 👍 the only thing I'm not sure about is the use_lockfile: true change. I understand the reasoning for the change and I'm happy to merge it, I just want us to be clear on a longer-term strategy as a team i.e. next steps

not intending to have that merged at all, but can't check CI for anything else right now as I don't know how to fix TS without that

@ef4 ef4 merged commit 739b8b5 into embroider-build:main May 30, 2023
196 checks passed
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@void-mAlex @mansona @NullVoxPopuli @ef4