Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the EMBROIDER_CONCAT_STATS build error #1524

Merged

Conversation

Windvis
Copy link
Collaborator

@Windvis Windvis commented Jul 11, 2023

Checking out the first commit should trigger the build error, the version bump fixes it.

Closes #1523

This adds a simple test which verifies that building with the EMBROIDER_CONCAT_STATS flag fails at the moment.
This version does support the named imports which resolves the build issue.
@ef4
Copy link
Contributor

ef4 commented Jul 12, 2023

Thanks, this looks good.

@ef4 ef4 merged commit 63f6836 into embroider-build:main Jul 12, 2023
187 of 188 checks passed
@Windvis Windvis deleted the fix/embroider-concat-stats-build-error branch July 12, 2023 07:22
@ef4 ef4 added the bug Something isn't working label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMBROIDER_CONCAT_STATS breaks the build
2 participants