Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML content failing to update #1597

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix HTML content failing to update #1597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/webpack/src/ember-webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ const Webpack: PackagerConstructor<Options> = class Webpack implements Packager
compiler => {
compiler.hooks.done.tapPromise('EmbroiderPlugin', async stats => {
this.summarizeStats(stats, variant, variantIndex);
await this.writeFiles(this.bundleSummary, appInfo, variantIndex);
await this.writeFiles(this.bundleSummary, this.lastAppInfo!, variantIndex);
});
},
],
Expand Down Expand Up @@ -294,6 +294,12 @@ const Webpack: PackagerConstructor<Options> = class Webpack implements Packager
private getWebpack(appInfo: AppInfo) {
if (this.lastWebpack && this.lastAppInfo && equalAppInfo(appInfo, this.lastAppInfo)) {
debug(`reusing webpack config`);
// the appInfos result in equal webpack configs so we don't need to
// reconfigure webpack. But they may contain other changes (like HTML
// content changes that don't alter the webpack config) so we still want
// lastAppInfo to update so that the latest one will be seen in the
// webpack post-build.
this.lastAppInfo = appInfo;
return this.lastWebpack;
}
debug(`configuring webpack`);
Expand Down