esbuild resolver for Vite dependency optimization#1614
Closed
lolmaus wants to merge 3 commits into
Closed
Conversation
Collaborator
Author
|
Here's a demo app that uses it and it has an issue (see comments over the link): |
lolmaus
force-pushed
the
esbuild-resolver
branch
from
October 2, 2023 10:29
26e7b9c to
d41d744
Compare
lolmaus
marked this pull request as ready for review
October 2, 2023 10:30
Collaborator
Author
|
@mansona and me have found the reason why the build of Instead of having Notes: |
| this.addResolverConfig(resolverConfig); | ||
| let babelConfig = this.babelConfig(resolverConfig); | ||
| this.addBabelConfig(babelConfig); | ||
| writeFileSync( |
NullVoxPopuli
approved these changes
Oct 3, 2023
NullVoxPopuli
approved these changes
Oct 3, 2023
NullVoxPopuli
left a comment
Collaborator
There was a problem hiding this comment.
I would feel better about this if we have some tests that used rollup build, but I understand there is a bit of a catch-22 here, and progress does need to be made.
lolmaus
marked this pull request as draft
October 11, 2023 14:26
Member
|
This went a different direction: #1650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking over @ef4's branch
esbuild-resolver. Rebased it againstmain.