-
Notifications
You must be signed in to change notification settings - Fork 147
esbuild resolver for Vite dependency optimization #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's a demo app that uses it and it has an issue (see comments over the link): |
26e7b9c
to
d41d744
Compare
@mansona and me have found the reason why the build of Instead of having Notes: |
@@ -989,6 +989,10 @@ export class CompatAppBuilder { | |||
this.addResolverConfig(resolverConfig); | |||
let babelConfig = this.babelConfig(resolverConfig); | |||
this.addBabelConfig(babelConfig); | |||
writeFileSync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✂️ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would feel better about this if we have some tests that used rollup build, but I understand there is a bit of a catch-22 here, and progress does need to be made.
This went a different direction: #1650 |
Taking over @ef4's branch
esbuild-resolver
. Rebased it againstmain
.