Add app-level watch-mode tests #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
watch-mode-tests
branch
from
c49a45c
to
e0a9dc7
Compare
NullVoxPopuli
commented
Oct 4, 2023
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
oofta. I cannot win today
lifeart
reviewed
Oct 6, 2023
|
|
||
| assert.false(await checkScripts(/js$/, content), 'file has not been created yet'); | ||
|
|
||
| fs.writeFile(path.join(app.dir, 'app/simple-file.js'), `export const two = "${content}";`); |
There was a problem hiding this comment.
should we here await for file creation?
There was a problem hiding this comment.
I guess yes technically 馃槀 but we have a thing just after that that is explicitly looking for the "app rebuild" notification which only happens after the file is written so it's safe to not await here 馃憤
mansona
force-pushed
the
watch-mode-tests
branch
from
38643b5
to
0b1b3b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds our first app-level watch-mode tests so we can start testing against some more involved scenarios that @chancancode has been fixing 馃帀