use package paths instead of relative paths for app tree resolving #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
app-tree
branch
3 times, most recently
from
57adb3d
to
04733ee
Compare
void-mAlex
reviewed
Oct 24, 2023
Merged
NullVoxPopuli
approved these changes
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked on #1651 because we can't really release code that depends on a shakey implementation of reverse-exports. We considered feature-flagging the change but it felt like a lot of work with very little gain 馃
Edit: I made this PR draft since it's blocked on needingreverse-exports馃憤Edit: reverse-exports was added in #1652 so this PR is good to go now