Refactor embroider-implicit-modules export pojo #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
changed the title
| lazyEngines, | ||
| eagerModules, | ||
| styles, | ||
| // this is a backward-compatibility feature: addons can force inclusion of modules. |
There was a problem hiding this comment.
thanks for the comment here!
There was a problem hiding this comment.
😂 the comment will need to be removed when this file gets coopted to do more stuff, this comment was just brought forward from the bit it was deleted from just above this 👍
NullVoxPopuli
approved these changes
Nov 7, 2023
NullVoxPopuli
previously approved these changes
Nov 7, 2023
mansona
force-pushed
the
virtual-implicit-modules
branch
from
913aee1
to
33572ea
Compare
mansona
dismissed
NullVoxPopuli’s stale review
PR isn't ready yet, we have a lot of tests to fix 🙈
mansona
force-pushed
the
virtual-implicit-modules
branch
3 times, most recently
from
ba2b508
to
0dfeb05
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
from
0dfeb05
to
5800603
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
from
5800603
to
a7bc4cd
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
from
b403fc2
to
9564bd0
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
from
9564bd0
to
cbec5d7
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
2 times, most recently
from
f73f0d6
to
996aeff
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
2 times, most recently
from
850b4bc
to
576dedb
Compare
mansona
force-pushed
the
virtual-implicit-modules
branch
from
576dedb
to
902e26a
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the work to a) remove the need for rewritten_app and b) eventually support vite