Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html clearing on rebuild #1661

Merged
merged 2 commits into from Nov 14, 2023
Merged

Fix html clearing on rebuild #1661

merged 2 commits into from Nov 14, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 14, 2023

There was a regression in #1605 that broke html clearing on rebuilds, which would cause all assets to get duplicated in the DOM.

(After removeChild(target), target.nextSibling goes undefined.)

Fixes #1660.

@ef4
Fix html clearing on rebuild
071fee9 
There was a regression in #1605 that broke html clearing on rebuilds, which would cause all assets to get duplicated in the DOM.

(After `removeChild(target)`, `target.nextSibling` goes undefined.)

Fixes #1660.
@ef4 ef4 merged commit ded6329 into main Nov 14, 2023
204 checks passed
@ef4 ef4 deleted the fix-html-clear branch November 14, 2023 19:05
@mansona mansona added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@void-mAlex void-mAlex void-mAlex approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rebuild issues with core 3.4.0 and compat 3.3.0
3 participants
@ef4 @void-mAlex @mansona