Disable chokidar polling override in tests #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event. Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box? Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else.
NullVoxPopuli
approved these changes
Dec 5, 2023
| @@ -39,11 +39,6 @@ export class DevWatcher { | |||
| configFile.options.map((options: RollupOptions) => { | |||
| options.watch = { | |||
| buildDelay: 20, | |||
| // Windows doesn't have a good file-watching mechanism (such as inotify), | |||
Closed
void-mAlex
added a commit
that referenced
this pull request
Dec 5, 2023
…09862bd7d79d899f55c8fda63 Backport #1703 to stable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into bugs/issues with using polling mode when writing tests for #1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the
addedevent.Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box?
Even if this is necessary we may want to limit it to the windows test only (can just set
CHOKIDAR_USEPOLLINGon the job level), since this makes things less realistic everywhere else.