Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable vite windows tests #1740

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

patricklx
Copy link
Contributor

No description provided.

@patricklx patricklx marked this pull request as ready for review December 21, 2023 16:42
// the value in engines are: C:\Users\RUNNER~1\AppData\Local\Temp\tmp-2256UvRXnGotcjxi\node_modules\.embroider\rewritten-app
// it looks like there is no way to fix this in JS with
// e.g fs.realpath, resolve, normalize
// Powershell command can be used, python could also resolve it...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@NullVoxPopuli NullVoxPopuli merged commit 241f631 into embroider-build:main Dec 21, 2023
205 checks passed
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants