control ember build through vite #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
vite-control-build
branch
3 times, most recently
from
a85ef34
to
eca61fa
Compare
mansona
requested changes
Feb 6, 2024
There was a problem hiding this comment.
We took a look at this during the Embroider meeting and there are a few things that we would like to see changed before this is mergable, but overall we're super excited about not needing two independent scripts running 🎉
Let me know if my comments don't make any sense, and we can open a thread in Discord to discuss 👍
patricklx
force-pushed
the
vite-control-build
branch
2 times, most recently
from
9ffe987
to
33a59f7
Compare
mansona
force-pushed
the
vite-control-build
branch
from
33a59f7
to
c50ae92
Compare
mansona
approved these changes
Feb 8, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also force optimizer rebundle when lock file changed.
this also solves an issue where the watcher did not detect changes if embroider build --watch was called after starting vite