Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vite build #1795

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix vite build #1795

merged 1 commit into from
Feb 14, 2024

Conversation

patricklx
Copy link
Contributor

No description provided.

@patricklx patricklx force-pushed the fix-vite-build branch 8 times, most recently from cae07bd to a1949cb Compare February 9, 2024 15:34
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 🎉 3 little changes and then we are good 👍

packages/vite/src/hbs.ts Outdated Show resolved Hide resolved
packages/vite/src/template-tag.ts Outdated Show resolved Hide resolved
tests/vite-app/vite.config.mjs Outdated Show resolved Hide resolved
@mansona mansona added the bug Something isn't working label Feb 14, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🚀

@mansona mansona merged commit f56eaf1 into embroider-build:main Feb 14, 2024
95 checks passed
@patricklx patricklx deleted the fix-vite-build branch February 14, 2024 11:03
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants