Make macro configs static #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
force-pushed
the
static-macros-config
branch
2 times, most recently
from
21ab0eb
to
c46b5b0
Compare
simonihmig
commented
Feb 26, 2024
| ? maybeFastbootMemberExpression.get('property') | ||
| : maybeFastbootMemberExpression.isOptionalMemberExpression() | ||
| ? maybeFastbootMemberExpression.get('property') | ||
| : assertNever(maybeFastbootMemberExpression); |
There was a problem hiding this comment.
This looks weird, but I found no better way to make TS happy. I had it first as simple as this:
You see the return type of .get('property') is not correct, it cannot be an array of NodePath, that makes no sense...
Those tertiary expressions narrow down the type before hitting .get() to make it return the correct type.
The type definition of .get() would not deal well with a union type (NodePath<MemberExpression> | NodePath<OptionalMemeberExpression> it seems, falling back to the second loosely typed one:
That tertiary expression would narrow down the type before hitting .get(), returning the expected correct type.
|
Failing tests are the same as those on master, fixed in #1817... |
…me implementation
simonihmig
force-pushed
the
static-macros-config
branch
from
c46b5b0
to
183dd97
Compare
ef4
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1804