Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the addon-template use vite #1864

Merged

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented Apr 4, 2024

Apps used in test scenarios are built out of an app template. Recently, one of these templates, app-template, has been modified so the output apps are built with vite. But addon-template hasn't been modified the same way. With the work on virtualization, we start to see test cases where we require the addon-template to output a dummy app building with vite as well.

This PR aligns addon-template with app-template to use vite:

  • aligns the dependencies
  • aligns vite and babel configs (+ ignores prettier)
  • change the test so there's no helper to be discovered at runtime (this no longer work because vite build use staticHelpers)

@BlueCutOfficial BlueCutOfficial force-pushed the addon-template-use-vite branch 2 times, most recently from 87fb0df to ae19562 Compare April 4, 2024 09:51
@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review April 4, 2024 10:04
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@mansona mansona merged commit b5fd677 into embroider-build:main Apr 4, 2024
90 checks passed
@BlueCutOfficial BlueCutOfficial deleted the addon-template-use-vite branch April 4, 2024 10:24
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants