-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix vite dep optimizer #1876
Open
patricklx
wants to merge
23
commits into
embroider-build:main
Choose a base branch
from
patricklx:fix-vite-dep-optimizer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix vite dep optimizer #1876
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1d3e0a1
use audit tests
patricklx fcd12af
Merge pull request #1885 from embroider-build/portable-babel-launcher
ef4 d14ecb0
more audit tests
patricklx 4174e2d
all deps are optimized
patricklx 5721195
delete old tests
patricklx 2c826de
lint
patricklx 294b4cb
fix tests
patricklx d30b44a
fix test
patricklx 3574896
fix
patricklx 2871df2
fix
patricklx 4f92ee1
fix tests
patricklx 283014e
wip
patricklx 0c406aa
move adjust virtual import into own resolve hook
patricklx 1780e23
fix
patricklx 3098cd6
fix compat-template-colocation test
patricklx 6833657
fix
patricklx 9070f88
improve node_modules detection
patricklx fa95030
fix windows
patricklx 4c1bb35
fix lint
patricklx fbd89e1
fix
patricklx c2f70f5
fix initial dep scan
patricklx d937128
update lock
patricklx 0f34b82
fix esbuild scan
patricklx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,11 @@ export default class Package { | |
|
||
@Memoize() | ||
protected get internalPackageJSON() { | ||
return JSON.parse(readFileSync(join(this.root, 'package.json'), 'utf8')); | ||
try { | ||
return JSON.parse(readFileSync(join(this.root, 'package.json'), 'utf8')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. workaround for fromFile pointing at /app/tests/package.json and vite/deps |
||
} catch { | ||
return {}; | ||
} | ||
} | ||
|
||
@Memoize() | ||
|
@@ -43,7 +47,7 @@ export default class Package { | |
} | ||
|
||
get meta(): AddonMeta | AppMeta | undefined { | ||
let m = this.packageJSON['ember-addon']; | ||
let m = this.packageJSON['ember-addon'] || {}; | ||
if (this.isV2App()) { | ||
return m as unknown as AppMeta; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignored should fallback resolve