improve audit tests #1919
Merged
improve audit tests #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
commented
May 16, 2024
| @@ -108,7 +108,7 @@ export default class CommandWatcher { | |||
| return; | |||
| } | |||
|
|
|||
| this.process.kill(); | |||
There was a problem hiding this comment.
vite needs to be killed with SIGINT (default is SIGTERM), otherwise it leaves the server subprocess running, which then leaves the port open
patricklx
commented
May 16, 2024
| }); | ||
|
|
||
| return { | ||
| async rerun() { |
There was a problem hiding this comment.
for tests that change files while vite dev is running we need to be able to rerun the vistors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.