Convert macro-sample-addon to new test scenario infra #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes test-packages/macro-sample-addon/*
thoov
force-pushed
the
macro-sample-addon-infra
branch
from
0a69c68
to
21bc6a9
Compare
stefanpenner
requested changes
Aug 27, 2021
|
|
||
| addonScenarios | ||
| .map('macro-sample-addon', project => { | ||
| let addonFiles = loadFromFixtureData('macro-sample-addon'); |
There was a problem hiding this comment.
Is there a reason to not use Project.fromDir ? If so, maybe we can add it upstream.
https://github.com/stefanpenner/node-fixturify-project/blob/4f81f02218b42c84db9baa801faed450b30f5129/index.ts#L263
https://github.com/stefanpenner/node-fixturify-project#linking-to-real-dependencies
| @@ -47,7 +47,6 @@ | |||
| "ember-auto-import": "^1.11.2", | |||
| "ember-cli": "~3.27.0", | |||
| "ember-cli-dependency-checker": "^3.1.0", | |||
| "ember-cli-eslint": "^5.1.0", | |||
There was a problem hiding this comment.
this was left-over anyways. good to delete!
|
I left one small nit, but otherwise this LGTM |
|
Chatting with @thoov he will follow up addressing (or atleast exploring) the nit more broadly, but that doesn't need to block the current PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes test-packages/macro-sample-addon/*