backing out ember real-modules mode #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it breaks many addons that aren't ready for the global `Ember` to be missing during vendor.js - it exacerabtes the problem of ember's internally-packaged deps (like route_recognizer) fighting with other copies We discussed making this a flag instead, but since then the plan is that Ember 4.0 itself will make ember-auto-import 2.0 mandatory, which smoothes the path to distributing ember-source as a v2 addon, in which case that should become the "flag" for doing static analysis of ember. Instead, all that was required was a compat adapter for `@glimmer/tracking`, since it's magic bullshit used to be handled by the modules-api-polyfill and now it needs to be handled differently.
5 tasks
Now that the fastboot-specific package.json output includes `type: 'addon'` within the ember metadata, it needs to come after the app's own ember metadata. Otherwise the app gets labeled as an addon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emberto be missing during vendor.jsWe discussed making this a flag instead, but since then the plan is that Ember 4.0 itself will make ember-auto-import 2.0 mandatory, which smoothes the path to distributing ember-source as a v2 addon, in which case that should become the "flag" for doing static analysis of ember.
Instead, all that was required for 3.27 compatibility was a compat adapter for
@glimmer/tracking, since its magic stuff used to be handled by the modules-api-polyfill and now it needs to be handled differently.The rewritten @glimmer/tracking is automatically inert on older ember versions because it never emits
implicit-modules, so it will only get included in the build if somebody is importing it, and under older ember versions nobody will import it because the imports get rewritten toEmber._tracked, etc.