Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate changelog entries for private packages #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 10, 2024

Alternate to: embroider-build/release-plan#60
(and more robust of an alternative than what's going on in that release-plan PR)

Resolves: embroider-build/create-release-plan-setup#91

Try this out via:

"pnpm": {
  "overrides": {
    "@ef4/lerna-changelog": "github:embroider-build/github-changelog#dist/ignore-private-packgaes",
  }
}

or

"pnpm": {
  "overrides": {
    "@ef4/lerna-changelog": "github:embroider-build/github-changelog#3ad92f5",
  }
}

Example: NullVoxPopuli/limber#1691

Outputted: NullVoxPopuli/limber#1673
image

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this feels closer to what we actually want to do 🎉 It's a long-standing issue in the pre-forked lerna changelog lerna/lerna-changelog#128 so I would really like it if our github-changelog could actually fix this for people and encourage them to switch 💪

This means that we should carefully read the issue and make sure that we cater for what people were asking for too 👍 and we need tests before we can merge this since it's a serious change 🙈

I'm requesting changes so we know we need tests before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private packgaes not ignored by changelog generation/preview
2 participants