Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustly discover packages with @manypkg #47

Merged
merged 4 commits into from Jan 24, 2024
Merged

Conversation

NullVoxPopuli
Copy link
Contributor

Resolves: #46
Requires: embroider-build/github-changelog#8 (included in this PR, as it is one half of the solution to #46)

Can test on your own repo with an override:

"pnpm": {
  "overrides": {
    "release-plan": "github:embroider-build/release-plan#tmp-manypkg-dist"
  }
}

Additionally, this should unlock the ability to remove --singlePackage, as @manypkg just works.

NullVoxPopuli added a commit to NullVoxPopuli/ember-resources that referenced this pull request Jan 11, 2024
NullVoxPopuli added a commit to NullVoxPopuli/ember-resources that referenced this pull request Jan 11, 2024
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review January 11, 2024 20:41
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the tooling meeting: we should add some basic tests here before proceeding

NullVoxPopuli added a commit to NullVoxPopuli/fix-bad-declaration-output that referenced this pull request Jan 23, 2024
@NullVoxPopuli
Copy link
Contributor Author

As discussed in the tooling meeting: we should add some basic tests here before proceeding

done -- I added two tests for some scenarios that I'm most immediately concerned with.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks

@mansona mansona merged commit 7ff9b46 into main Jan 24, 2024
2 checks passed
@mansona mansona deleted the robustly-discovery-packages branch January 24, 2024 13:44
@mansona mansona added the enhancement New feature or request label Jan 24, 2024
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
@mansona
Copy link
Member

mansona commented Jan 24, 2024

I marked this as an enhancement because it changes the internal implementation of something. Really it's a bugfix because it's trying to fix a specific bug but it's too much of a big change to just be considered a bugfix 👍

edit: i forgot that we are pre-1.0 so actually an "enchancement" is really a bugfix 😭 maybe this is something that we should codify in release-plan

@mansona mansona added bug Something isn't working and removed enhancement New feature or request labels Jan 24, 2024
NullVoxPopuli added a commit to NullVoxPopuli/fix-bad-declaration-output that referenced this pull request Jan 24, 2024
NullVoxPopuli added a commit to NullVoxPopuli/fix-bad-declaration-output that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks upon switching .npmrc (in a pnpm monorepo) to ues shared-workspace-lockfile=false
3 participants