Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove withXml { ... } #37

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Remove withXml { ... } #37

merged 1 commit into from
Mar 31, 2023

Conversation

dmikurube
Copy link
Member

I forgot that withXml { ... } does not work with the embulk-plugins Gradle plugin.

It's not mandatory. Let's remove them now.

@dmikurube
Remove withXml { ... }
f7d112c 
I forgot that withXml { ... } does not work with the embulk-plugins Gradle plugin.

It's not mandatory. Let's remove them now.
@dmikurube dmikurube added this to the v0.10.41 milestone Mar 31, 2023
@dmikurube dmikurube requested a review from a team as a code owner March 31, 2023 09:54
@dmikurube
Copy link
Member Author

dmikurube commented Mar 31, 2023 •
edited

Oops, sorry, I forgot this...

hiroyuki-sato
hiroyuki-sato approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 4959386 into master Mar 31, 2023
@dmikurube dmikurube deleted the remove-withXml branch March 31, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.10.41
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmikurube @hiroyuki-sato