Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for explicit null in CSV quote and escape #43

Merged
merged 2 commits into from
Apr 29, 2023
Merged

Fix for explicit null in CSV quote and escape #43

merged 2 commits into from
Apr 29, 2023

Conversation

dmikurube
Copy link
Member

@dmikurube dmikurube commented Apr 28, 2023 •
edited

CSV parser's behavior was not compatible with older versions when null is specified explicitly for quote or escape.

cdd9ce3 is to confirm it fails by tests, and 5d3d3a7 fixes it.

@dmikurube dmikurube added this to the v0.10.42 milestone Apr 28, 2023
@dmikurube dmikurube changed the title Test to fail how quote/escape configurations are applied to CsvTokenizer Fix for explicit null in CSV quote and escape Apr 28, 2023
@dmikurube dmikurube requested review from legiangthanh and a team April 28, 2023 04:32
@dmikurube dmikurube marked this pull request as ready for review April 28, 2023 04:33
@dmikurube
Copy link
Member Author

@legiangthanh You may want to have a look at this.

legiangthanh
legiangthanh approved these changes Apr 28, 2023
View reviewed changes
Copy link

@legiangthanh legiangthanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

hiroyuki-sato
hiroyuki-sato approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 46862a3 into master Apr 29, 2023
3 checks passed
@dmikurube dmikurube deleted the fix-quote-escape-null branch April 29, 2023 12:34
@dmikurube dmikurube mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

@legiangthanh legiangthanh legiangthanh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.10.42
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmikurube @hiroyuki-sato @legiangthanh